November Source Bug/ Dupe Fix Release

[Scura]

1 hour ago, Veni said:




better way is to first remove the wear position from the packet itself. the client does not need to send that info to the server, the server should check and determine that itself.



so in the end you should do something like this:



 




CItem* item = ch->m_inventory.getItem(packet->tab, packet->invenIndex);

int wearPos;
wearPos = item->m_itemProto->getItemWearing()

// change all packet->wearPos to the varaible like this

if (wearPos < 0 || wearPos >= MAX_WEARING)
{
CNetMsg::SP rmsg(new CNetMsg);
ResponseClient::ItemWearMsg(rmsg, ResponseClient::WEAR_ERR_INVALID_POS);
SEND_Q(rmsg, ch->m_desc);
return ;
}


Sure, you check if it's an "APet", but you dont check if its a normal pet. With this you also dont check if the item is an experience booster.



If you see code like this you should fix it properly and not just half of it




What about:

.
.
.
CItem* item = ch->m_inventory.getItem(packet->tab, packet->invenIndex); // ÀÔ´Â ¾ÆÀÌÅÛ

int wearPos;
wearPos = item->m_itemProto->getItemWearing();

if (packet->wearPos != WEARING_PET && item->IsAPet() || wearPos < 0 || wearPos >= MAX_WEARING)
{
CNetMsg::SP rmsg(new CNetMsg);
ResponseClient::ItemWearMsg(rmsg, ResponseClient::WEAR_ERR_INVALID_POS);
SEND_Q(rmsg, ch->m_desc);
return;
}
.
.
.