Get Current Online user of the channel under the Radar?

[nicolasg]

1 hour ago, Andrein95 said:




/index.php?/profile/14423-nicolasg/&do=hovercard" data-mentionid="14423" href="/index.php?/profile/14423-nicolasg/" rel="">@nicolasg



In my opinion you did well, in SessionStateInfo we can not access directly ChannelInfo, only using cascade if with pointer and make a lot of exxternal inclusion (server select,server info ecc)


IMPLEMENT_MSG_UPDATE(OnlinePlayers) {
UpdateClient::OnlinePlayersInfo* pPack = reinterpret_cast<UpdateClient::OnlinePlayersInfo*>(istr->GetBuffer());
_pNetwork->PlayersCounter = (pPack->PlayersOnline);
}


Here instead we can access directly without make dirty this function.



To summarize:



The nice approach would not be to load players counter for the first time in some constructor of the radar using pChannelInfo and then on RadarUpdate Function to retrieve from pNetwork?




Yes, you could skip all check statements, and copy the value from iPlayerNum into PlayersCounter just once. It would be a cleaner code and you would consume less resources in each execution of the loop